Updated Convert and Testing code to address TABs #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erjenkin
approved these changes
Mar 26, 2021
bcwilhite
approved these changes
Apr 29, 2021
bcwilhite
added a commit
that referenced
this pull request
Jun 1, 2021
* updated AccessControlList to an array (#869) * Remove CodeCov due to lack of use * Updated Convert and Testing code to address TABs (#867) * Updated Convert and Testing code to address TABs * Updated changelog * Testing SQL 2016 Stig convert - no manual actions * Corrected paths in Build.yaml * Added missing comment about for ExcludeModuleFile * Fixes comments with space after # Co-authored-by: Brian Wilhite <bcwilhite@live.com> * Parse Chrome STIG 2.3 and fix tab issue in desc * Updated Changelog.md * Updated comment about TAB replace in code * Updated Hard coded rule * Add SQL Server 2016 STIG Vulnerability ID's. (#874) * ConvertFactory - Added SQLServerDscRule * SQLServerDscRule : Added rule, convert, and method files. * LoadFactory : Added SQLServerDscRule * SQLServerSchema : Added SQLServerConfiguration resource script * SQLServerConfiguration : Added resource script * PowerStig.Convert : Added SQLServerDsc convert rule * Data.ps1 : Added SQLServerDscRule * SQLServerConfiguration : Made changes to follow style guidelines * Added SQLServerDscRule unit testing * Added remaining SQLServerDsc Configurations to unit test * SQLServerDscRule:: Added exceptionhelp notes * SQLServerDscRule.tests: Reworked pester tests for v4. * SQlServerDScRule.tests: Removed commented out code. * SQLServerDscRule.tests: PowerShell style guide fix * SQLServerDscRule.Integration: Added integration tests * Changelog.md: Updated changelog * SqlServerDscRule: Removed upper case letters for guideline compliance * SQLServerDscRule.Integration: Added last empty line * Methods: Added last empty line * Loadfactory: Removed tab * SQLServerDscRule.Convert: Added last empty line * SQLServerDscRule: Fixed upper case style * SQLServerDSCRule: Resolved class typo * Style guidelines fix and rename class to SQLServerConfigurationRule * SqlServer XML: Updated XML with new ID's * Fixed V-213975 to match STIG; Recreated XML for SQL 2016 2VR2 / 2VR1 * Converted SQL 2012 XML * Updated SQLServerConfiguration rule pester tests * Methods.ps1:: Code consolidation for checkcontent. * Data.ps1 :: Fixed spacing * Fixed style guideline issues :: Updated unit tests for SqlServerConfigurationRule * Rename SQLServerConfigurationRule.tests.ps1 to SqlServerConfigurationRule.tests.ps1 * Rename SQLServerConfigurationRule.Integration.tests.ps1 to SqlServerConfigurationRule.Integration.tests.ps1 * SqlServerConfigurationRule:: Updated unit pester test formatting. * style guideline fixes. Co-authored-by: Brian Wilhite <bcwilhite@live.com> * Update PowerSTIG to successfully parse/apply Microsoft IIS 8.5 SITE/SERVER STIG - Ver 2, Rel 2 (#886) * updated to add support for iis 8.5 v2r2 * updated to add IIS site/server 8.5 * Update PowerSTIG to successfully parse/apply Red Hat Enterprise Linux 7 STIG - Ver 2, Rel 2 (#892) * added support for RHEL7 V3R3 * added new line to archive STIG xml * Update PowerSTIG to successfully parse/apply Microsoft Windows Server 2019 STIG - Ver 2, Rel 2 (#895) * added Windows 2019 DC / MS V2R2 * removed old processed 2019 STIGs * added support for 2016 V2R2 (#899) * Update PowerSTIG to successfully parse/apply Microsoft Windows 2012 R2 MS STIG - Ver 3, Rel 2 (#901) * added support for 2012 MS V3R2 * removed old 2012 MS 2.19 processed STIG * updated to add support for sql 2016 instance v2r3 (#906) Co-authored-by: Brian Wilhite <bcwilhite@live.com> * Update PowerSTIG to successfully parse/apply Microsoft Windows 2012 Server Domain Name System STIG - Ver 2, Rel 2 #896 (#898) * Parse Windows DNS 2012 ver 2.2 * removed 1.15 2012 DNS Co-authored-by: Brian Wilhite <bcwilhite@live.com> * Update PowerSTIG to successfully parse/apply Microsoft IIS 10.0 SITE/SERVER STIG - Ver 2, Rel 2 (#907) * add support for IIS 10 V2R2 * updated org settings * removed N-2 IIS 10 1.2 processed STIGs Co-authored-by: Brian Wilhite <bcwilhite@live.com> * added support for 2012 DC V3R2 (#908) * Update PowerSTIG to successfully parse/apply Windows 10 STIG V2 R2 (#894) * updated to add windows 10 v2r2 support * update based on feedback Co-authored-by: Brian Wilhite <bcwilhite@live.com> * Update PowerSTIG to parse/apply Microsoft Office 365 ProPlus STIG - Ver 2, Rel 2 (#889) * updated to inclue proplus v2r2 * updated org settings Co-authored-by: Brian Wilhite <bcwilhite@live.com> * updated changelog and filehash for release * updated readme.md with addavenp1 as contributor Co-authored-by: hinderjd <hinderjd@gmail.com> Co-authored-by: Jason Patton <46757047+japatton@users.noreply.github.com> Co-authored-by: addavenp1 <82848693+addavenp1@users.noreply.github.com> Co-authored-by: Eric Jenkins <erjenkin@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description:
Remove TAB's during conversion from DISA STIG to PowerStig format.
Ignore Archive folder during HQRM testing.
This Pull Request (PR) fixes the following issues:
This fixes #
#864
Task list:
This change is